[VAULTS] Polish Permissions contract and other minor improvements #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hardhat Unit Tests Coverage SummaryDiff against masterResults for commit: fdb7a08 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
TheDZhon
reviewed
Jan 31, 2025
| * @notice The order of confirmations does not matter | ||
| * | ||
| */ | ||
| modifier onlyMutuallyConfirmed(bytes32[] memory _roles) { |
There was a problem hiding this comment.
let's check for the empty _roles
Comment on lines
22
to
27
| mapping(bytes32 callId => mapping(bytes32 role => uint256 timestamp)) public confirmations; | ||
|
|
||
| /** | ||
| * @notice Confirmation lifetime in seconds; after this period, the confirmation expires and no longer counts. | ||
| */ | ||
| uint256 public confirmLifetime; |
There was a problem hiding this comment.
should it be non-linear storage though?
| * - role: role that confirmed the action | ||
| * - timestamp: timestamp of the confirmation. | ||
| */ | ||
| mapping(bytes32 callId => mapping(bytes32 role => uint256 timestamp)) public confirmations; |
There was a problem hiding this comment.
should we add some getters to make it more accessible?
| * the confirmation is considered expired, no longer counts and must be recasted for the confirmation to go through. | ||
| * @param _newConfirmLifetime The new confirmation lifetime in seconds. | ||
| */ | ||
| function _setConfirmLifetime(uint256 _newConfirmLifetime) internal { |
There was a problem hiding this comment.
can track the last confirmation timestamp and revert this function if new conf precedes it
| @@ -97,18 +89,18 @@ contract Dashboard is Permissions { | |||
| /** | |||
| * @notice Initializes the contract with the default admin role | |||
There was a problem hiding this comment.
outdated comment (doesn't mention the second parameter)
There was a problem hiding this comment.
treasuryFee -> treasuryFeeBP and maybe other similar cases
There was a problem hiding this comment.
wrong comment:
/**
* @notice Withdraws stETH tokens from the staking vault to wrapped ether.
* @param _recipient Address of the recipient
* @param _amountOfWETH Amount of WETH to withdraw
*/
function withdrawWETH(address _recipient, uint256 _amountOfWETH) external {
_withdraw(address(this), _amountOfWETH);
WETH.deposit{value: _amountOfWETH}();
SafeERC20.safeTransfer(WETH, _recipient, _amountOfWETH);
}
have similar issues for other utility functions here and there
There was a problem hiding this comment.
plz consider revamping comment sections
|
|
||
| /** | ||
| * @notice Mass-grants multiple roles to multiple accounts. | ||
| * @param _assignments An array of role assignments. |
There was a problem hiding this comment.
maybe note that duplicates wouldn't revert the call rather resulting in fewer events emitted (and cover this behavior with tests)
There was a problem hiding this comment.
maybe prohibit zero address for NodeOperator
failingtwice
force-pushed
the
permissions-polish
branch
from
a3c4a13 to
fce5c97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes minor improvements to Permissions, some refactoring and improvements